Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algoliaPlacesApplicationID has a wrong name #106

Open
ghost opened this issue Mar 9, 2017 · 1 comment
Open

algoliaPlacesApplicationID has a wrong name #106

ghost opened this issue Mar 9, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 9, 2017

Hello,

In the code line 23080 of ods-widgets.js

there is :

if (ODSWidgetsConfig.algoliaPlacesApplicationId) {

but the config parameter is :

ODSWidgetsConfig.algoliaPlacesApplicationID

Even if user set algoriaPlacesApplicationID,

options.headers = { 'X-Algolia-Application-Id': ODSWidgetsConfig.algoliaPlacesApplicationID, 'X-Algolia-API-Key': ODSWidgetsConfig.algoliaPlacesAPIKey };

is never applied

thanks

@richterb
Copy link
Contributor

richterb commented Mar 9, 2017

Hello,

Indeed, nice find. We never encountered the issue so far because Algolia's rate limit is high enough without an API key...

We fixed it on our side and the fix will be in the next release. If you want to fix it on your end, the obvious fix should work (changing ODSWidgetsConfig.algoliaPlacesApplicationID to ODSWidgetsConfig.algoliaPlacesApplicationId).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant