Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to DataScienceCluster component statuses for basic OpenShift Console users #588

Closed
andrewballantyne opened this issue Oct 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@andrewballantyne
Copy link
Member

Is your feature request related to a problem? Please describe.
The Dashboard would like to start relying heavily on the status of the Operator's DSC CR, so we can know what components are installed so we can override our feature flags. Ideally this will grow to support issues with installation issues of components. (eg. opendatahub-io/odh-dashboard#1886 -- which seems to have some details already)

Describe the solution you'd like
An out-of-the-box role to grant all system:authenticated users access to the .status of the DSC.

akin to kubectl create role foo --verb=get,list,watch --resource=pods/status

Describe alternatives you've considered

  • The Dashboard Service Account pulls the information and filters it before handing it off to the Dashboard client.
  • A new resource, like a configmap/CR or something could hold onto the information about install status

Additional context
A final note on how we approach this: we will just have to be careful about any information we put on the status and make sure we aren’t leaking any potentially sensitive information about the underlying cluster. Such as any human readable messages

@zdtsw
Copy link
Member

zdtsw commented Oct 3, 2023

i think the more accurate one to use is InstalledComponents from .status of DSC to use.
in case, the component is enabled but keep reconciling , it gets to set to false.

@andrewballantyne
Copy link
Member Author

It should be noted -- this seems not possible to do at a subresource only level. My test & results can be found on slack.

@AjayJagan
Copy link
Contributor

Migrated to JIRA: https://issues.redhat.com/browse/RHOAIENG-493, hence closing it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Status: No status
Status: Done
Development

No branches or pull requests

3 participants