Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Allow for non-english characters where it should be allowed. #1968

Closed
erwangranger opened this issue Oct 13, 2023 · 4 comments · Fixed by #1974
Closed

[Bug]: Allow for non-english characters where it should be allowed. #1968

erwangranger opened this issue Oct 13, 2023 · 4 comments · Fixed by #1974
Assignees
Labels
feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. rhods-1.35 rhods-2.4

Comments

@erwangranger
Copy link

erwangranger commented Oct 13, 2023

ODH Component

ODH Dashboard

Current Behavior

From https://issues.redhat.com/browse/RHODS-6346 and slack: https://redhat-internal.slack.com/archives/C03UGJY6Z1A/p1697115227770089

In various fields, it's possible to type in some non-english characters, but it then becomes impossible to save.

When saving, there is an error stating:

----
the object provided is unrecognized (must be of type Secret): 
couldn't get version/kind; json parse error: 
unexpected end of JSON input ({"apiVersion":"v1","kind":"Sec ...)

Some examples:

image

image

Expected Behavior

For each field where I can write text:

  • Either the special characters are allowed, and they should be saved properly
  • Or they are disallowed, and the application should clearly indicate it to the user, instead of failing to save.

Steps To Reproduce

here are some sample characters to test with:

à 
é
ł (unicode hex 0142) 
Ĥ (unicode hex 124)

Workaround (if any)

No response

What browsers are you seeing the problem on? (If applicable)

No response

Open Data Hub Version

RHODS 1.33

Anything else

No response

@erwangranger erwangranger added the kind/bug Something isn't working label Oct 13, 2023
@dgutride dgutride added the field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality label Oct 16, 2023
@lucferbux
Copy link
Contributor

/transfer odh-dashboard

@openshift-ci openshift-ci bot transferred this issue from opendatahub-io/opendatahub-community Oct 16, 2023
@lucferbux lucferbux added feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) needs-info Further information is requested from the reporter or from another source labels Oct 16, 2023
@lucferbux lucferbux moved this from Untriaged to Dev To do in ODH Dashboard Planning Oct 16, 2023
@andrewballantyne
Copy link
Member

It appears this is done in YAML editor in OpenShift Console pretty straight forward. That might be the monaco editor and that might be the OpenShift Console. I don't think this needs-info anymore. We can manage these values however they do. Looks to be some conversation of the string.

@andrewballantyne andrewballantyne added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. and removed needs-info Further information is requested from the reporter or from another source labels Oct 16, 2023
@christianvogt christianvogt self-assigned this Oct 17, 2023
@christianvogt christianvogt moved this to In Progress in Internal tracking Oct 17, 2023
@christianvogt christianvogt moved this from Dev To do to Dev In progress in ODH Dashboard Planning Oct 17, 2023
@github-project-automation github-project-automation bot moved this from Dev In progress to Done in ODH Dashboard Planning Oct 17, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Internal tracking Oct 17, 2023
@manosnoam
Copy link
Contributor

This has been reported since RHODS 1.20... https://issues.redhat.com/browse/RHODS-7329.
This is now fixed in RHODS 2.4:
It is not allowed to enter unsupported Unicode characters in specified fields:
image

@manosnoam
Copy link
Contributor

@andrewballantyne please note that this specific bug was resolved with a proper error message, but related bugs were not:
RHODS-12901 - No input validation when updating existing resource

RHODS-6346 - Missing input validation in item creation forms/fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. rhods-1.35 rhods-2.4
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants