OSSM: General Improvements

[cam-garrison]

Creating this issue to encompass several pieces of review + suggestions from the original PR #1088 which were not included in the PR.

          I suggest adding the same comment as we have present in the frontend code.

/**
 * Feature flags are required in the config -- but upgrades can be mixed and omission of the property
 * usually ends up being enabled. This will prevent that as a general utility.
 */
export const featureFlagEnabled = (disabledSettingState?: boolean): boolean =>
  disabledSettingState === false;

Originally posted by @christianvogt in #1088 (comment)

          ? getRoute(notebookName, projectName).then((route) => route.spec.host)

Originally posted by @christianvogt in #1088 (comment)

          Should we fall back to retrieving the host through the route?

By enabling the flag without service mesh, we'll get an invalid url.

    if (enableServiceMesh) {
      host = await getServiceMeshGwHost(fastify, namespace).catch((e) => {
        fastify.log.warn(`Failed getting service mesh route ${notebookName}: ${e.message}`);
        return undefined;
      });
    }
    if (!host) {
      const route = await getRoute(fastify, namespace, notebookName).catch((e) => {
        fastify.log.warn(`Failed getting route ${notebookName}: ${e.message}`);
        return undefined;
      });
      host = route?.spec.host;
    }

Originally posted by @christianvogt in #1088 (comment)

[andrewballantyne]

PR closed