Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM: Consolidate Service Mesh related notebook patches #1954

Closed
cam-garrison opened this issue Oct 11, 2023 · 1 comment · Fixed by #1955
Closed

OSSM: Consolidate Service Mesh related notebook patches #1954

cam-garrison opened this issue Oct 11, 2023 · 1 comment · Fixed by #1955
Assignees
@cam-garrison
Labels
feature/ossm OpenShift Service Mesh kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue.

Comments

@cam-garrison
Copy link

cam-garrison commented Oct 11, 2023 •
edited
Loading

These seem all very related, we may want to look at cleaning that up in the future to make it one "set of patches" rather than 3 separate ones. Just for code cleanness.

Originally posted by @andrewballantyne in #1088 (comment)

Currently, we have 3 separate functions that return patches for the 2 annotations and 1 label that need to be patched in the notebook object to enable/disable service mesh. For code cleanness, these three patches should be returned in one function call.
@cam-garrison cam-garrison self-assigned this Oct 11, 2023
This was referenced Oct 11, 2023
Merged
Closed
@andrewballantyne andrewballantyne linked a pull request Oct 11, 2023 that will close this issue
[Service Mesh] include SM notebook patches in one function #1955
Merged
7 tasks
@lucferbux lucferbux moved this from Untriaged to Dev To do in ODH Dashboard Planning Oct 16, 2023
@andrewballantyne andrewballantyne added feature/ossm OpenShift Service Mesh kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. labels Oct 30, 2023
@dgutride
Copy link
Contributor

dgutride commented Dec 8, 2023

Associated PR was merged - moving to closed (please add a comment if this was incorrect).

@dgutride dgutride closed this as completed Dec 8, 2023
@github-project-automation github-project-automation bot moved this from Dev To do to Done in ODH Dashboard Planning Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cam-garrison cam-garrison

Labels
feature/ossm OpenShift Service Mesh kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue.
Projects
Internal tracking
Status: Done
ODH Feature Tracking
Status: No status
ODH Dashboard Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Service Mesh] include SM notebook patches in one function cam-garrison/odh-dashboard
3 participants
@dgutride @andrewballantyne @cam-garrison