Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker]: Default-less Storage Class DS Project #1919

Open
andrewballantyne opened this issue Oct 6, 2023 · 3 comments
Open

[Tracker]: Default-less Storage Class DS Project #1919

andrewballantyne opened this issue Oct 6, 2023 · 3 comments
Labels
community feature/storage-classes Storage Classes feature tracker Non-completable ticket; used for tracking work - akin to a Jira Epic

Comments

@andrewballantyne
Copy link
Member

andrewballantyne commented Oct 6, 2023

Description

When we do not have a default (annotation storageclass.kubernetes.io/is-default-class: 'true') value on a StorageClass in the cluster, DS Projects just fail, no way around it.

We have a desire to support full set of storage classes, admin UI and the ability to override an existing default on the cluster and prefer a different one for ODH. That's tracked under:

This effort should only deal with a gap today, where your cluster has no default.

Target Branch

f/storage-class

Requirements

  • List all storage classes (all users should have access RBAC wise)
  • Look for a default storage class
    • if one is found, do nothing (continue with the flow today)
    • If one is not found, read the spec.notebookController.storageClassName value
      • if set & in the list, use it on the name on the PVC
      • if not set, do nothing (continue with the flow today)
      • if set & not in the list, print an error to the dev console console.error(...) and do nothing else (continue with the flow today)

Itemized UX Issues

N/A -- Entirely under the hood.

Itemized Dev Issues

Related artifacts

No response

@andrewballantyne andrewballantyne added tracker Non-completable ticket; used for tracking work - akin to a Jira Epic feature/storage-classes Storage Classes feature labels Oct 6, 2023
@andrewballantyne andrewballantyne self-assigned this Oct 6, 2023
@andrewballantyne andrewballantyne moved this from Untriaged to Trackers in ODH Dashboard Planning Oct 6, 2023
@andrewballantyne andrewballantyne moved this from Trackers to Incubating in ODH Dashboard Planning Oct 6, 2023
@shalberd
Copy link
Contributor

@andrewballantyne this particular tracker can be considered closed. What is described in requirements works. While #1270 is the more all-encompassing tracker.

@andrewballantyne
Copy link
Member Author

@shalberd I was going to keep this open as an option for us to take this to RHODS for self-managed deployments that may want their own state of storage classes. I'd close it when we moved to writing the larger Storage Class feature.

@shalberd
Copy link
Contributor

sounds good, thank you for the heads-up

@andrewballantyne andrewballantyne removed their assignment Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community feature/storage-classes Storage Classes feature tracker Non-completable ticket; used for tracking work - akin to a Jira Epic
Projects
Status: No status
Status: No status
Status: Incubating
Development

No branches or pull requests

2 participants