From bbbe4f335a98223bcc903382f9463e2e7781e436 Mon Sep 17 00:00:00 2001 From: Jan Stourac Date: Wed, 10 Jul 2024 12:52:42 +0200 Subject: [PATCH] update contributing guide --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cdb41d0c1..0fe8ada90 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -56,3 +56,8 @@ Pull requests are the best way to propose changes to the notebooks repository: ### Testing your PR locally - Test the changes locally, by manually running the `$make jupyter-${NOTEBOOK_NAME}-ubi8-python-3.8` from the terminal. This definitely helps in that initial phase. + +### Review and Merge process + +- Once the PR is submitted, you can either select particular reviewers or leave the bot to select reviewers automatically. +- To make PR merged, it has to get 2 `/lgtm` comments first from the repository [approvals/reviewers](/OWNERS). Then an `/approve` comment must be added by someone with approval rights. If the author of the PR has approval rights, it's preferred that he's the one who performs the merge action.