From 27202f26472787c1398d1b7e54c11652be574a7f Mon Sep 17 00:00:00 2001 From: Jan Stourac Date: Tue, 9 Jul 2024 14:14:22 +0200 Subject: [PATCH 1/2] Update OWNERS file with adding more approvers --- OWNERS | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/OWNERS b/OWNERS index abcc8a24c2c..238c8a85a9b 100644 --- a/OWNERS +++ b/OWNERS @@ -1,6 +1,10 @@ approvers: - atheo89 + - caponetto - harshad16 + - jiridanek + - jstourac + - paulovmr reviewers: - atheo89 From 3321e726876cfd4113deee88600b5910962ad7be Mon Sep 17 00:00:00 2001 From: Jan Stourac Date: Mon, 15 Jul 2024 16:11:01 +0200 Subject: [PATCH 2/2] update the contributing guide --- CONTRIBUTING.md | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d7b6310f18f..a5bf54fbaef 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,13 +1,4 @@ -# Kubeflow Contributor Guide +### Review and Merge Process -Welcome to the Kubeflow project! We'd love to accept your patches and -contributions to this project. Please read the -[contributor's guide in our docs](https://www.kubeflow.org/docs/about/contributing/). - -The contributor's guide - -* shows you where to find the Contributor License Agreement (CLA) that you need - to sign, -* helps you get started with your first contribution to Kubeflow, -* and describes the pull request and review workflow in detail, including the - OWNERS files and automated workflow tool. +- Once the PR is submitted, you can either select specific reviewers or let the bot to select reviewers [automatically](https://prow.ci.openshift.org/plugins?repo=opendatahub-io%2Fnotebooks). +- For the PR to be merged, it must receive 2 reviews from the repository [approvals/reviewers](/OWNERS). Following that, an `/approve` comment must be added by someone with approval rights. If the author of the PR has approval rights, it is preferred that they perform the merge action.