Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Endpoint Tasks #371

Closed
Jooho opened this issue Jun 6, 2024 · 2 comments
Closed

Private Endpoint Tasks #371

Jooho opened this issue Jun 6, 2024 · 2 comments
Assignees
Labels
kind/enhancement Enhancement to current features

Comments

@Jooho
Copy link

Jooho commented Jun 6, 2024

This is tracking GH issue.

@Jooho
Copy link
Author

Jooho commented Jun 6, 2024

Full test

Setup Test Environment to verify all PRs
PR list

images

  • quay.io/jooholee/odh-model-controller:private
  • quay.io/jooholee/kserve-controller:private
  • quay.io/jooholee/opendatahub-operator:private
  • quay.io/jooholee/opendatahub-operator-catalog:0.0.0

Manual way

Install custom odh operator/kserve operator/odh-model-controller operator


Script way

Loopy Setup
refer this doc

git clone   [email protected]:Jooho/loopy.git
cd loopy
make init
 
or

docker run -it quay.io/jooholee/loopy

cat cluster_info.sh
CLUSTER_CONSOLE_URL=https://console-openshift-console.XXXX
CLUSTER_API_URL=https://api.XXX:443
CLUSTER_ADMIN_ID=admin
CLUSTER_ADMIN_PW=password
CLUSTER_TOKEN=sha256~XXX
CLUSTER_TYPE=ROSA

Install Kserve with a new manifests

loopy playbooks run private-endpoint-poc -p CUSTOM_KSERVE_MANIFESTS=https://github.com/jooho/kserve/tarball/test-manifest  -p CUSTOM_ODH_MODEL_CONTROLLER_MANIFESTS=https://github.com/jooho/odh-model-controller/tarball/test-manifests -vvv -i ./cluster_info.sh

Deploy sample sklearn model

loopy units run test-kserve-sklearn-v2-iris-role -vvv -i ./cluster_info.sh 

Test from the same namespace

  1. Running test pods
TEST_NAMESPACE=kserve-demo

oc label namespace ${TEST_NAMESPACE} pod-security.kubernetes.io/enforce=baseline --overwrite
oc label namespace ${TEST_NAMESPACE} pod-security.kubernetes.io/warn=baseline --overwrite
oc label namespace ${TEST_NAMESPACE} pod-security.kubernetes.io/audit=baseline  --overwrite

oc run test-with-istio  -n ${TEST_NAMESPACE} --image=registry.access.redhat.com/rhel7/rhel-tools --annotations=sidecar.istio.io/inject="true" -- sleep infinity 2> /dev/null
oc run test  -n ${TEST_NAMESPACE} --image=registry.access.redhat.com/rhel7/rhel-tools -- sleep infinity 2> /dev/null
  1. curl from a pod with istio-proxy from the same cluster
oc exec test-with-istio -n ${TEST_NAMESPACE} -- curl -s sklearn-example-isvc-iris-v2-rest.${TEST_NAMESPACE}.svc.cluster.local/v2/health/live
  1. curl from a pod without istio-proxy from the same cluster
oc exec test -n ${TEST_NAMESPACE}  -- curl -sk https://sklearn-example-isvc-iris-v2-rest.${TEST_NAMESPACE}.svc.cluster.local/v2/health/live

Test from another namespace

  1. Running test pods
ANOTHER_NAMESPACE=curl-test
oc new-project ${ANOTHER_NAMESPACE}
oc label namespace ${ANOTHER_NAMESPACE} pod-security.kubernetes.io/enforce=baseline --overwrite
oc label namespace ${ANOTHER_NAMESPACE} pod-security.kubernetes.io/warn=baseline --overwrite
oc label namespace ${ANOTHER_NAMESPACE} pod-security.kubernetes.io/audit=baseline  --overwrite
cat << EOF |oc create -f -
kind: ServiceMeshMember
apiVersion: maistra.io/v1
metadata:
  name: default
  namespace:  ${ANOTHER_NAMESPACE} 
spec:
  controlPlaneRef:
    name: data-science-smcp
    namespace: istio-system
EOF


oc run test-with-istio  -n  ${ANOTHER_NAMESPACE}  --image=registry.access.redhat.com/rhel7/rhel-tools -n ${ANOTHER_NAMESPACE}  --annotations=sidecar.istio.io/inject="true" -- sleep infinity 2> /dev/null
oc run test  -n  ${ANOTHER_NAMESPACE}  --image=registry.access.redhat.com/rhel7/rhel-tools -n ${ANOTHER_NAMESPACE} -- sleep infinity 2> /dev/null
  1. curl from a pod with istio-proxy from another cluster
oc exec test-with-istio  -n ${ANOTHER_NAMESPACE} -- curl -s sklearn-example-isvc-iris-v2-rest.${TEST_NAMESPACE}.svc.cluster.local/v2/health/live
  1. curl from a pod without istio-proxy from another cluster
oc exec test -n ${ANOTHER_NAMESPACE} -- curl -sk https://sklearn-example-isvc-iris-v2-rest.${TEST_NAMESPACE}.svc.cluster.local/v2/health/live 

@Jooho Jooho self-assigned this Jun 12, 2024
@Jooho Jooho added kind/enhancement Enhancement to current features and removed kind/bug Something isn't working labels Jun 13, 2024
@Jooho
Copy link
Author

Jooho commented Nov 2, 2024

all done

@Jooho Jooho closed this as completed Nov 2, 2024
@github-project-automation github-project-automation bot moved this from New/Backlog to Done in ODH Model Serving Planning Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement to current features
Projects
Status: Done
Development

No branches or pull requests

1 participant