Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setup.py to trigger GitHub show dependents #927

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

dkurt
Copy link
Member

@dkurt dkurt commented Dec 9, 2023

Currently, GitHub cannot parse setup.py to detect dependencies/dependents (so no Used By section appears like in https://github.com/numpy/numpy).

Goal of this PR is to use a common syntax for setuptools with setup. Perhaps, GitHub ignores skbuild

Current SBOM from https://github.com/opencv/opencv-python/network/dependencies:
opencv-python_opencv_7cfd1ee8ecc52f9466af29b63440703fc635011b.json

@dkurt
Copy link
Member Author

dkurt commented Dec 9, 2023

@asmorkalov, @mshabunin, please review

@dkurt
Copy link
Member Author

dkurt commented Dec 13, 2023

@asmorkalov, just a reminder

@asmorkalov asmorkalov self-requested a review December 21, 2023 09:47
@asmorkalov asmorkalov self-assigned this Dec 21, 2023
Copy link
Collaborator

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 91555be into opencv:4.x Dec 21, 2023
117 of 125 checks passed
@dkurt
Copy link
Member Author

dkurt commented Dec 21, 2023

It's working now! https://github.com/opencv/opencv-python/network/dependents
image

@dkurt dkurt deleted the try_enable_dependents branch December 21, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants