Bugfix: Shape mismatch when converting Slice op from ONNX to IR. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In model-optimizer/extensions/middle/SliceConverter.py, there is an error when parsing the end-slice of the slice. When comparing end-slice with input shape, input shape of the dimension which match the end-slice's dimension should have been used. However, the indexing of input shape is wrong. This bugfix changes two lines, fixing the wrong indexing.
|
Can one of the admins verify this patch? |
|
@lazarevevgeny is it still relevant? |
|
The fix has been already applied. Refer to https://github.com/openvinotoolkit/openvino/blob/master/model-optimizer/extensions/middle/SliceConverter.py#L151-L157. Closing the PR. |
eshoguli
pushed a commit
to eshoguli/openvino
that referenced
this pull request
Jun 1, 2021
akuporos
added a commit
that referenced
this pull request
Aug 30, 2023
* first snippet * part1 * update model state snippet * add temp dir * CPU snippets update (#134) * snippets CPU 1/6 * snippets CPU 2/6 * snippets CPU 3/6 * snippets CPU 4/6 * snippets CPU 5/6 * snippets CPU 6/6 * make module TODO: REMEMBER ABOUT EXPORTING PYTONPATH ON CIs ETC * Add static model creation in snippets for CPU * export_comp_model done * leftovers * apply comments * apply comments -- properties * small fixes * add serialize * rempve debug info * return IENetwork instead of Function * apply comments * revert precision change in common snippets * update opset * [PyOV] Edit docs for the rest of plugins (#136) * modify main.py * GNA snippets * GPU snippets * AUTO snippets * MULTI snippets * HETERO snippets * Added properties * update gna * more samples * Update docs/OV_Runtime_UG/model_state_intro.md * Update docs/OV_Runtime_UG/model_state_intro.md --------- Co-authored-by: Jan Iwaszkiewicz <[email protected]> Co-authored-by: Karol Blaszczak <[email protected]>
akuporos
added a commit
that referenced
this pull request
Sep 13, 2023
* [Docs][PyOV] update python snippets * first snippet * Fix samples debug * Fix linter * part1 * Fix speech sample * update model state snippet * add serialize * add temp dir * CPU snippets update (#134) * snippets CPU 1/6 * snippets CPU 2/6 * snippets CPU 3/6 * snippets CPU 4/6 * snippets CPU 5/6 * snippets CPU 6/6 * make module TODO: REMEMBER ABOUT EXPORTING PYTONPATH ON CIs ETC * Add static model creation in snippets for CPU * export_comp_model done * leftovers * apply comments * apply comments -- properties * small fixes * rempve debug info * return IENetwork instead of Function * apply comments * revert precision change in common snippets * update opset * [PyOV] Edit docs for the rest of plugins (#136) * modify main.py * GNA snippets * GPU snippets * AUTO snippets * MULTI snippets * HETERO snippets * Added properties * update gna * more samples * Update docs/OV_Runtime_UG/model_state_intro.md * Update docs/OV_Runtime_UG/model_state_intro.md * attempt1 fix ci * new approach to test * temporary remove some files from run * revert cmake changes * fix ci * fix snippet * fix py_exclusive snippet * fix preprocessing snippet * clean-up main * remove numpy installation in gha * check for GPU * add logger * iexclude main * main update * temp * Temp2 * Temp2 * temp * Revert temp * add property execution devices * hide output from samples --------- Co-authored-by: p-wysocki <[email protected]> Co-authored-by: Jan Iwaszkiewicz <[email protected]> Co-authored-by: Karol Blaszczak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In model-optimizer/extensions/middle/SliceConverter.py, there is an error when parsing the end-slice of the slice. When comparing end-slice with input shape, input shape of the dimension which match the end-slice's dimension should have been used. However, the indexing of input shape is wrong.
This bugfix changes two lines, fixing the wrong indexing.