Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC2024] Update datumaro dependency after merge of PR#36 #7703

Closed

Conversation

teja1412-hub
Copy link

Motivation and context

Updating the dependency of cvat on datumaro after recent merges PR #36 in datumaro to fix issue #7258

Checklist

  • I submit my changes into the develop branch
    - [ ] I have created a changelog fragment
    - [ ] I have updated the documentation accordingly
    - [ ] I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
    - [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@teja1412-hub teja1412-hub changed the title [GSoc2024] Update datumaro dependency after merge of PR#36 [GSoC2024] Update datumaro dependency after merge of PR#36 Mar 29, 2024
@zhiltsov-max
Copy link
Contributor

Please run the command from the README to actually update the dependencies.

@zhiltsov-max zhiltsov-max mentioned this pull request Apr 2, 2024
7 tasks
@teja1412-hub teja1412-hub requested a review from azhavoro as a code owner April 3, 2024 19:26
@teja1412-hub teja1412-hub marked this pull request as draft April 3, 2024 19:26
@teja1412-hub teja1412-hub marked this pull request as ready for review April 3, 2024 19:29
@teja1412-hub
Copy link
Author

@zhiltsov-max, can you review the PR now.

zhiltsov-max added a commit that referenced this pull request Apr 5, 2024
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->

Closes #7703
Related: #7258
Related: #7125
Related: #7699

Changes:
cvat-ai/datumaro@8a14a99...82982b1

- Fixed WiderFace dataset example
- Fixed export without images in Datumaro format - no empty `media` and
`point_cloud` fields should be in the results

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
@zhiltsov-max
Copy link
Contributor

Included in #7716

@teja1412-hub teja1412-hub deleted the update-datumaro-dependency branch April 6, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants