Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools-v2]:add bs stop volume snapshot #2579

Open
Cyber-SiKu opened this issue Jun 28, 2023 · 10 comments
Open

[tools-v2]:add bs stop volume snapshot #2579

Cyber-SiKu opened this issue Jun 28, 2023 · 10 comments
Assignees
Labels

Comments

@Cyber-SiKu
Copy link
Contributor

Cyber-SiKu commented Jun 28, 2023

Registration procedure

Step 1. Add a comment when you sign up.The purpose of comments is for us to understand you and determine whether you have the basic ability to complete this issue.

  • If you are a student, please introduce your school, major, programming language, technical fields of interest, what you are good at, and why you chose this issue.
  • If you are already working, please introduce your company, career, work content, technical fields of interest, and why you chose this issue.

Step 2. Use WeChat to add the Curve community assistant "Curve" as a WeChat friend, tell your GitHub ID, and send the Issue link of your choice. The assistant will invite you to communicate with the mentor by WeChat.

Step 3. In order to better complete each development task, the mentor will select the developer who best matches the issue based on everyone's comment on GitHub and communication status by WeChat. If you are not selected, please select another issue.

Tips

  • Before developing, please read the dev guideline( https://ask.opencurve.io/t/topic/201) carefully and communicate with your mentor.
  • Please submit a draft PR before 11.29, and the mentor will review it within 2-5 working days and may guide you to modify the PR based on the actual situation.
  • If you successfully merge into PR before 12.27 and you will receive gifts carefully prepared by the Curve community.

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

we'd like to support bs delete copyset snapshot command in curve tool

Describe the solution you'd like (描述你期望的解决方法)

  • The implementation of the old tool is here:

elif args.optype == "cancel-snapshot":
delete_or_cancel_snap.delete_or_cancel_snapshot(delete_or_cancel_snap.CANCELSNAPSHOT, args)

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@Cyber-SiKu Cyber-SiKu added the enhancement improve feature label Jun 28, 2023
@Cyber-SiKu Cyber-SiKu changed the title [tools-v2]:add bs stop copyset snapshot [tools-v2]:add bs stop volume snapshot Jun 28, 2023
@ZackSoul
Copy link
Contributor

ZackSoul commented Aug 8, 2023

I want to assign this issue

@ZackSoul
Copy link
Contributor

ZackSoul commented Aug 17, 2023

issue
Do I need to implement these two functions from curtools.py using Go, or are there already corresponding functions implemented in Go?Also, which parameter in Go corresponds to the UUID in the arguments?

@Cyber-SiKu
Copy link
Contributor Author

issue Do I need to implement these two functions from curtools.py using Go, or are there already corresponding functions implemented in Go?Also, which parameter in Go corresponds to the UUID in the arguments?

There should be no need for you to implement this aspect. For uuid, you can look at the implementation of the original python code and implement the corresponding parameters yourself.

@ZackSoul
Copy link
Contributor

ZackSoul commented Sep 4, 2023

Hi, I have read the source code of the python implementation and implemented the main framework of the code, but I don't find the relevant rpc for canceling the snapshot as shown in the picture, what should I do?
interface

@Cyber-SiKu
Copy link
Contributor Author

Hi, I have read the source code of the python implementation and implemented the main framework of the code, but I don't find the relevant rpc for canceling the snapshot as shown in the picture, what should I do? interface

Read the source code, you can see that this should send an http request instead of an rpc Request, follow this to implement a go version.

@ZackSoul
Copy link
Contributor

ZackSoul commented Sep 5, 2023

Yes, I know that the python implementation does this by sending the http request, but I didn't find the rpc about this command in the go language version, does this mean that I need to implement the relevant rpc command myself.

@Cyber-SiKu
Copy link
Contributor Author

Yes, I know that the python implementation does this by sending the http request, but I didn't find the rpc about this command in the go language version, does this mean that I need to implement the relevant rpc command myself.

Here Send http request, if it is not suitable, you can add it one.

@ZackSoul
Copy link
Contributor

I want to assign this issue

@CrystalAnalyst
Copy link
Contributor

CrystalAnalyst commented Oct 30, 2023

Hi, I'm a junior major in computer science in HangzhouDianzi University currently. I am familiar with programming languages like Golang and C++. (Also, I'm a newbie to Rust). I'm interested in WebFramework Development, Cloud-Native, Distributed System and Storage System. I'm good at Golang development and familiar with the go stand library. I wish I can take on this issue to pracitce my skills and capability further. Please assign it to me.

@Subzeroo7
Copy link

Hi, I'm a junior major in computer science in HangzhouDianzi University currently. I am familiar with programming languages like Golang and C++. (Also, I'm a newbie to Rust). I'm interested in WebFramework Development, Cloud-Native, Distributed System and Storage System. I'm good at Golang development and familiar with the go stand library. I wish I can take on this issue to pracitce my skills and capability further. Please assign it to me.

Sorry,this issue has been assigned,please choose others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants