Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curvefs]: change s3info #2517

Open
Cyber-SiKu opened this issue Jun 7, 2023 · 6 comments
Open

[curvefs]: change s3info #2517

Cyber-SiKu opened this issue Jun 7, 2023 · 6 comments
Assignees
Labels
curvefs enhancement improve feature good first issue Good for newcomers

Comments

@Cyber-SiKu
Copy link
Contributor

Cyber-SiKu commented Jun 7, 2023

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

At present, the backend s3 information stored in the curve file can only be specified when it is created, and cannot be changed later. But this will cause a problem: once the user's ak and sk are leaked, the fs becomes unavailable after changing the ak and sk.

At this time, the client's s3 information is also unavailable, and the client needs to be notified.

Describe the solution you'd like (描述你期望的解决方法)

I hope to add an interface and use tools to modify the information of s3 (ak, sk, bucket, endpoint).

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@Cyber-SiKu Cyber-SiKu added enhancement improve feature good first issue Good for newcomers curvefs labels Jun 7, 2023
@harshitcodes22
Copy link

Assign me this please

@Cyber-SiKu
Copy link
Contributor Author

Assign me this please

done

@Cyber-SiKu
Copy link
Contributor Author

Cyber-SiKu commented Aug 2, 2023

This is the pr that supports multi-s3 before, you can make a reference
#1132

@Cyber-SiKu
Copy link
Contributor Author

@harshitcodes22
If you find it difficult now, you can take three steps (three PRs are enough):

  1. Modify s3info in fsinfo on the mds side
  2. After the mds is modified, notify the metaserver and update the s3adaptor
  3. Notify the client after modification and update s3adaptor

@ken90242
Copy link
Contributor

ken90242 commented Nov 3, 2023

I am a software engineer at a tech company, working on the company's product business logic. I am interested in C++ and distributed systems.

I chose this topic because I previously worked on several issues for CurveFS, and I want to learn more about Curve design and implementation details.

@zztaki
Copy link
Contributor

zztaki commented Dec 5, 2023

If this problem is not completed when the deadline is over or this friend gives up, please let me try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
curvefs enhancement improve feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants