Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print error code with more meaningful name #2185

Open
wu-hanqing opened this issue Jan 5, 2023 · 21 comments
Open

print error code with more meaningful name #2185

wu-hanqing opened this issue Jan 5, 2023 · 21 comments
Assignees
Labels
enhancement improve feature good first issue Good for newcomers

Comments

@wu-hanqing
Copy link
Contributor

curve has three types of error codes

now, in some error path, we only print the raw value of them instead of more meaningful name which result in bad experience.

@wu-hanqing wu-hanqing added enhancement improve feature good first issue Good for newcomers labels Jan 5, 2023
@yamicro
Copy link

yamicro commented Jan 20, 2023

Hi, I am a newbie in c++ and interested in this issue to try it out. I would like to know if there is some additional information that can help me understand this issue and this project better.

@beertocode
Copy link

can i be assigned this issue

@ilixiaocui
Copy link
Contributor

can i be assigned this issue

Thank you very much for your interest in this issue, this issue will be assigned to you.

@wuhongsong
Copy link
Contributor

@beertocode Are you working on this task? any help?

@Cyber-SiKu
Copy link
Contributor

@beertocode Is this still going on?

@gueFDF
Copy link

gueFDF commented Feb 28, 2023

Please assign me.

@ilixiaocui ilixiaocui assigned gueFDF and unassigned beertocode Feb 28, 2023
@ilixiaocui
Copy link
Contributor

@beertocode Due to no feedback for a long time, the issue is reassigned.

@ilixiaocui
Copy link
Contributor

Please assign me.

Welcome!

@gueFDF
Copy link

gueFDF commented Mar 3, 2023

Hello, I encountered an error when submitting pr, but I don't seem to understand what happened. The error message is as follows:

GitHub pull request #2286 of commit d817215, no merge conflicts.
Running as SYSTEM
Setting status of d817215 to PENDING with url http://59.111.91.248:8080/job/waiting_in_line/2082/ and message: 'Build started for merge commit.'
[EnvInject] - Loading node environment variables.
Building remotely on failover-slave3 (curve-failover-build3) in workspace /home/nbs/jenkins/workspace/waiting_in_line
[waiting_in_line] $ /bin/bash /tmp/jenkins4459845953071838805.sh
No build required,fail
ERROR: [GitHub Commit Status Setter] - Cannot retrieve Git metadata for the build, setting build result to FAILURE
Build step 'Set build status on GitHub commit [deprecated]' changed build result to FAILURE
Setting status of d817215 to FAILURE with url http://59.111.91.248:8080/job/waiting_in_line/2082/ and message: 'Build finished. '
Finished: FAILURE

@wu-hanqing
Copy link
Contributor Author

wu-hanqing commented Mar 3, 2023

Hello, I encountered an error when submitting pr, but I don't seem to understand what happened. The error message is as follows:

GitHub pull request #2286 of commit d817215, no merge conflicts.
Running as SYSTEM
Setting status of d817215 to PENDING with url http://59.111.91.248:8080/job/waiting_in_line/2082/ and message: 'Build started for merge commit.'
[EnvInject] - Loading node environment variables.
Building remotely on failover-slave3 (curve-failover-build3) in workspace /home/nbs/jenkins/workspace/waiting_in_line
[waiting_in_line] $ /bin/bash /tmp/jenkins4459845953071838805.sh
No build required,fail
ERROR: [GitHub Commit Status Setter] - Cannot retrieve Git metadata for the build, setting build result to FAILURE
Build step 'Set build status on GitHub commit [deprecated]' changed build result to FAILURE
Setting status of d817215 to FAILURE with url http://59.111.91.248:8080/job/waiting_in_line/2082/ and message: 'Build finished. '
Finished: FAILURE

hi, waiting_in_line is used to prevent PR been merged before passing CI, and you should comment cicheck to manually trigger it. And I have done this, you can check the results.

@gueFDF
Copy link

gueFDF commented Mar 3, 2023

Oh, I see, thank you so much.

@wu-hanqing
Copy link
Contributor Author

@gueFDF you don't have to close and recreate a new pull request if you change something, just add and commit you changes, then git push, the pull request will automatically update

@gueFDF
Copy link

gueFDF commented Mar 6, 2023

@gueFDF you don't have to close and recreate a new pull request if you change something, just add and commit you changes, then git push, the pull request will automatically update

I see, thank you.

@Cyber-SiKu
Copy link
Contributor

@gueFDF Are you still going on?

@XR-stb
Copy link
Contributor

XR-stb commented Jul 4, 2023

how should i to find the error path with raw value, i try to search the raw value, but can't find anymore

@wu-hanqing
Copy link
Contributor Author

how should i to find the error path with raw value, i try to search the raw value, but can't find anymore

Mostly, these error codes/types are usually used as a return value rather than the original value. So, you can try to find places to use them.

@NopeDl
Copy link
Contributor

NopeDl commented Aug 2, 2023

can i be assigned this issue?

@XR-stb
Copy link
Contributor

XR-stb commented Aug 2, 2023

how should i to find the error path with raw value, i try to search the raw value, but can't find anymore

Mostly, these error codes/types are usually used as a return value rather than the original value. So, you can try to find places to use them.

Okay, I know what to do. Thank you, okay

@XR-stb
Copy link
Contributor

XR-stb commented Aug 2, 2023

Is this task over? I see that the event registration there has stopped applying, but see that this issue has not been closed

@wu-hanqing
Copy link
Contributor Author

Hi, @XR-stb since we didn't receive a response for a long time, we put this issue in developer activity and it has been assigned to NopeDl.
It's our mistake for not telling you earlier, you can still find issues of interest and participate in this event from here, #2603.

@XR-stb
Copy link
Contributor

XR-stb commented Aug 2, 2023

Hi, @XR-stb since we didn't receive a response for a long time, we put this issue in developer activity and it has been assigned to NopeDl. It's our mistake for not telling you earlier, you can still find issues of interest and participate in this event from here, #2603.

Okay, that's okay, I'll see if there's other thing I can do to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

10 participants