Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curve tool]: implement delete volume command #2030

Closed
cw123 opened this issue Nov 4, 2022 · 1 comment
Closed

[curve tool]: implement delete volume command #2030

cw123 opened this issue Nov 4, 2022 · 1 comment
Assignees
Labels
good first issue Good for newcomers tools Tool improvements

Comments

@cw123
Copy link
Contributor

cw123 commented Nov 4, 2022

Describe the feature you'd like:

we'd like to support delete volume command in curve tool

delete is one of the commands to delete one volume.

  • The implementation of the old tool is here:

https://github.com/opencurve/curve/blob/master/src/tools/namespace_tool_core.cpp#L58

  • The old command:
delete : delete the file, to force delete, should specify the --forcedelete=true

$ curve_ops_tool delete --example
Example:
curve_ops_tool delete -mdsAddr=127.0.0.1:6666 -fileName=/test -userName=test -password=123 -forcedelete=true

  • The new command we want:
curve bs delete --filename /curvebs-file-name --username username [--password password] [--forcedelete true]

If command sucess, print success.
If command failed, print failed, and the fail reason.

Teachability, Documentation, Adoption, Migration Strategy:

Refer to tool develop guide to get start, and paste the result of the command in pr.

Build compilation environment:https://github.com/opencurve/curve/blob/master/docs/cn/build_and_run.md

@cw123 cw123 added good first issue Good for newcomers tools Tool improvements labels Nov 4, 2022
@cw123 cw123 changed the title [curve tool]: implement delete command [curve tool]: implement delete volume command Nov 4, 2022
@shentupenghui
Copy link
Contributor

i would like solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tools Tool improvements
Projects
None yet
Development

No branches or pull requests

4 participants