rotate service logs using logrotate tool #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caoxianfei1
reviewed
Sep 1, 2023
README.md
Outdated
| ``` | ||
|
|
||
| ```shell | ||
| $ kubectl create configmap log-conf --from-file=config/samples/logrotate.conf |
There was a problem hiding this comment.
The configmap should create in code.
caoxianfei1
reviewed
Sep 1, 2023
pkg/mds/spec.go
Outdated
| }, | ||
| } | ||
| return container | ||
| } |
There was a problem hiding this comment.
If the test passes, it can be encapsulated into a function as final commit.
caoxianfei1
changed the title
|
@Zero3River sqush to one commit. |
Zero3River
force-pushed
the
add-logrotate
branch
4 times, most recently
from
15b8d7c to
c745018
Compare
Zero3River
force-pushed
the
add-logrotate
branch
from
c745018 to
286296e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logrotate sidecar container for etcd, mds and chunkserver. Also provide a default configuration file for logrotate in config/samples #76