refactor: fix failing e2e test for all places referencing a full name #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SInce we introduced the ability to allow countries to customise the order for a full name and the default being {surname} {middlename} {firstname} the tests need to conform to that
opencrvs/opencrvs-core#6830
This comment has been minimized.
This comment has been minimized.
Siyasanga
changed the title
6 tasks
|
Your environment is deployed to https://ocrvs-6830-human-name-constant.opencrvs.dev. |
There were some screens that were not using the new customised formatName() so the refactor to formatName broke thier e2e tests, the temporary solution is to add a new function formatNameWithFirstNameFirst() which uses the old logic until the screen are updated opencrvs/opencrvs-core#6830
Siyasanga
force-pushed
the
ocrvs-6830-human-name-constant
branch
from
3b80c0c to
a886c0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix e2e tests after introducing a way to allow countries to customise the order of a full name. turns out there were alot of other screens that use a full name so the changes to the
formatName()broke a lot of e2e tests. Instead of fixing the tests we've put temporary logicfullNameWithFirstNameFirst()helper function which will get removed once all the screens use theformatName()function.opencrvs/opencrvs-core#6830