Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In performance, Informant column is showing blank in Registration by status #6157

Open
SyedaAfrida opened this issue Nov 3, 2023 · 16 comments · May be fixed by #7947
Open

In performance, Informant column is showing blank in Registration by status #6157

SyedaAfrida opened this issue Nov 3, 2023 · 16 comments · May be fixed by #7947
Assignees
@Siyasanga
Labels
Bug 💅 Waiting For Review
Milestone
2025 Horizon

Comments

@SyedaAfrida
Copy link
Collaborator

SyedaAfrida commented Nov 3, 2023 •
edited by Zangetsu101
Loading

Bug description:
In performance, Informant column is showing blank in Registration by status

Steps to reproduce:

  1. Login to RA/ local Registrar
  2. Click Performance
  3. Filter any office
  4. In Regsitration by status click any link
  5. Observe informant column

Actual result:
In performance, Informant column is showing blank in Registration by status

Expected result:
Should show relationship to child/ deceased, email address and phone number

Screenshot:

In.performance.Informant.column.is.showing.blank.in.Registartion.by.status.mp4

Tested on:
https://login.niue.opencrvs.org/?lang=en
@SyedaAfrida SyedaAfrida added Priority: low Doesn't have a considerable negative impact on the codebase at the moment 🇳🇺 Niue bug labels Nov 3, 2023
@github-project-automation github-project-automation bot moved this to In Design in OpenCRVS Core Nov 3, 2023
@jpye-finch jpye-finch added Bug and removed bug labels Nov 22, 2023
@jpye-finch jpye-finch moved this from In Design to Backlog in OpenCRVS Core Nov 22, 2023
@jpye-finch jpye-finch removed the Priority: low Doesn't have a considerable negative impact on the codebase at the moment label May 27, 2024
@SyedaAfrida
Copy link
Collaborator Author

This bug is also in core

@euanmillar euanmillar moved this from Backlog to Ready to build in OpenCRVS Core Jun 7, 2024
@euanmillar euanmillar added this to the v1.5.0 milestone Jun 7, 2024
@Zangetsu101
Copy link
Collaborator

Similar to #7100

@Nil20 Nil20 self-assigned this Jun 12, 2024
@Nil20 Nil20 moved this from Ready to build to In Development in OpenCRVS Core Jun 12, 2024
@Nil20
Copy link
Collaborator

Nil20 commented Jun 12, 2024

Fix: #6157

@Zangetsu101 Zangetsu101 moved this from In Development to In Code Review in OpenCRVS Core Jun 13, 2024
@Zangetsu101 Zangetsu101 mentioned this issue Jun 14, 2024
Closed
@Zangetsu101
Copy link
Collaborator

This needs to be cherry-picked for Niue

@Zangetsu101 Zangetsu101 moved this from In Code Review to Pending for release cherry-pick in OpenCRVS Core Jul 1, 2024
@Zangetsu101 Zangetsu101 moved this from Pending for release cherry-pick to Ready to QA in OpenCRVS Core Jul 1, 2024
@Zangetsu101 Zangetsu101 moved this from Ready to QA to In QA in OpenCRVS Core Jul 3, 2024
@Zangetsu101
Copy link
Collaborator

Older declarations might not show the proper value on 1.5, it should get fixed automatically in 1.6

@SyedaAfrida
Copy link
Collaborator Author

Will be tested in V1.6.0

@SyedaAfrida SyedaAfrida modified the milestones: v1.5.0, v1.6.0 Jul 9, 2024
@tiri39
Copy link
Collaborator

tiri39 commented Jul 12, 2024

Found following issues -

  1. For some of the old declarations (created in v1.5.0) the relationship to child / deceased is not showing in the informant column.
6157_relationship_to_child_or_deceased_missing.mp4
  1. When the informant is Someone Else , for the old declarations the Informant column shows the specific relationship (for ex - uncle / aunt etc.) that was provided while creating the declaration; but for new (created in v1.6.0) declarations it shows Other family member . Should show Someone else or the specific relationship.
6157_new_records_say_other_family_member_for_someone_else.mp4

@Nil20
Copy link
Collaborator

Nil20 commented Jul 26, 2024

The reindexing issue should be fixed in #6345

@Zangetsu101 Zangetsu101 moved this from In Development to Ready to build in OpenCRVS Core Jul 27, 2024
@euanmillar euanmillar modified the milestones: v1.6.0, v1.7.0 Jul 29, 2024
@euanmillar
Copy link
Collaborator

@jpye-finch I am moving this to 1.7.0 as the Performance re-design #6261 may mean that a bugfix in this area is not required.

@Siyasanga Siyasanga self-assigned this Sep 11, 2024
@Siyasanga Siyasanga moved this from Ready to build to In Development in OpenCRVS Core Sep 11, 2024
@Siyasanga
Copy link
Collaborator

Hi @tiri39 I'm currently on the develop branch, and this issue seems to be fixed. Can you please confirm if you still experiencing this bug on your environment?

@Zangetsu101
Copy link
Collaborator

I think we can send it to the QA column now as the reindexing issue has been fixed, so this one should automatically get fixed as well

@Siyasanga Siyasanga moved this from In Development to In QA in OpenCRVS Core Sep 18, 2024
@onnee04
Copy link
Collaborator

onnee04 commented Nov 5, 2024

@Siyasanga when we select "Someone else" as informant, it shows "other family member".
Expected result: when we select "Someone else" as informant, it should show "Someone else".

6157.mp4

@onnee04 onnee04 moved this from In QA to Ready to build in OpenCRVS Core Nov 5, 2024
@Siyasanga Siyasanga moved this from Ready to build to In Development in OpenCRVS Core Nov 5, 2024
@Siyasanga Siyasanga moved this from In Development to Ready to build in OpenCRVS Core Nov 5, 2024
@Siyasanga Siyasanga moved this from Ready to build to In Development in OpenCRVS Core Nov 7, 2024
Siyasanga added a commit that referenced this issue Nov 11, 2024
@Siyasanga
fix: UserelationSomeoneElse tranlation for Other option 4 form
79f6706 
We were using a wrong translation for the "Someone else" option for the birth form.

#6157
@Siyasanga Siyasanga linked a pull request Nov 11, 2024 that will close this issue
Open
Siyasanga added a commit that referenced this issue Nov 11, 2024
@Siyasanga
Record PR chagnges in the CHANGELOG
c11fe2c 
#6157
@Siyasanga Siyasanga linked a pull request Nov 11, 2024 that will close this issue
fix: 'UserelationSomeoneElse' translation for Other option 4 form #7947
Open
Siyasanga added a commit that referenced this issue Nov 11, 2024
@Siyasanga
Rename otherFamilyMember to someoneElse
d4609a3 
We no longer have the field as otherFamilyMember in the birth form so for clarity we are using the actual label that is expected for the someone else option

#6157
@tiri39
Copy link
Collaborator

tiri39 commented Nov 25, 2024

Not Fixed.

Still shows 'Other family member' when 'someone else' is selected as informant.

Farajaland.CRS.-.Google.Chrome.2024-11-25.18-06-18.online-video-cutter.com.mp4

@tiri39 tiri39 moved this from Ready for QA to Ready to build in OpenCRVS Core Nov 25, 2024
@Zangetsu101
Copy link
Collaborator

@tiri39 sorry my bad, this is actually deployed to a separate environment

@Zangetsu101
Copy link
Collaborator

https://ocrvs-6157.opencrvs.dev/

@tiri39
Copy link
Collaborator

tiri39 commented Nov 27, 2024

Fixed.

Farajaland.CRS.-.Google.Chrome.2024-11-27.15-45-06.mp4

@tiri39 tiri39 moved this from Ready for QA to Ready for release in OpenCRVS Core Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Siyasanga Siyasanga

Labels
Bug 💅 Waiting For Review
Projects
OpenCRVS Core
Status: Ready for release
Milestone
2025 Horizon
Development

Successfully merging a pull request may close this issue.

fix: 'UserelationSomeoneElse' translation for Other option 4 form opencrvs/opencrvs-core
9 participants
@euanmillar @Siyasanga @Zangetsu101 @Nil20 @jpye-finch @eduffus @onnee04 @SyedaAfrida @tiri39