Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cost-reporter): update dashboards names and ids #8

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat(cost-reporter): update dashboards names and ids #8

merged 1 commit into from
Nov 12, 2024

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Oct 17, 2024 •
edited
Loading

What does this PR change?

  • Update name and id of opencost cost reporter basic overview dashboard
  • Update name and id of opencost cost reporter detailed overview dashboard

How will this PR impact users?

  • ID change

How was this PR tested?

  • Imported into grafana

@aslafy-z aslafy-z changed the title feat: update naming feat: update dashboard naming Oct 17, 2024
@aslafy-z aslafy-z marked this pull request as ready for review October 17, 2024 16:56
@aslafy-z
Copy link
Contributor Author

cc @asdfgugus

@asdfgugus
Copy link
Contributor

@aslafy-z thanks for the PR!
LGTM! 🚀
Could you please combine the commits into one?

@aslafy-z aslafy-z changed the title feat: update dashboard naming feat(cost-reporter): update dashboards names and ids Oct 18, 2024
@aslafy-z
Copy link
Contributor Author

@asdfgugus Done :)

asdfgugus
asdfgugus approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@asdfgugus asdfgugus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I would like to wait for @mattray to review the changes as well.

@asdfgugus asdfgugus merged commit ac9bb49 into opencost:main Nov 12, 2024
@aslafy-z aslafy-z deleted the patch-1 branch November 13, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdfgugus asdfgugus asdfgugus approved these changes

@mattray mattray Awaiting requested review from mattray

Assignees
No one assigned
Labels
needs-follow-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslafy-z @asdfgugus