Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename models to lib #204

Closed
jcscottiii opened this issue Jul 22, 2016 · 0 comments · Fixed by #205
Closed

rename models to lib #204

jcscottiii opened this issue Jul 22, 2016 · 0 comments · Fixed by #205

Comments

@jcscottiii
Copy link
Member

jcscottiii commented Jul 22, 2016

Feeling inspired by https://peter.bourgon.org/go-best-practices-2016/#repository-structure
To make it clear in terms which packages should be imported by other projects, we should have a lib folder. I think models is essentially that.

After we do that, we need to go through the code and see what's exported vs private inside lib
The interfaces should be exported. The concrete structs should be private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants