-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New project: opencontainers/go-digest #21
Comments
SGTM, this would require 2/3 vote via @opencontainers/tob to formalize it as a project We would also need a list of initial MAINTAINERS. We could opt on creating a project proposal similar to what the OCI Tools project did awhile ago for clarity: https://github.com/opencontainers/tob/blob/master/proposals/tools.md |
This proposal LGTM. Agreed MAINTAINERS seems critical, just mapping it to the image-spec would be fine with me but I would be fine with other arrangements as well under @stevvooe's discretion. |
@caniszczyk @philips Thank you! I would propose that the maintainers be the image-spec containers. I'll volunteer to be "lead maintainer" of this package, if we have such a thing. If there are objections, please let me know. The level activity on this project should be minimal, as it is fairly mature. If it wasn't clear for the proposal, https://github.com/docker/go-digest would be copied over and we would then update the front matter to match OCI project requirements. |
I've update the description with details, so people know what they're voting on. |
LGTM |
@caniszczyk I keep clicking that link and it keeps taking me back to this issue. I think you meant #22. |
@stevvooe you're right, sorry about that, fixed the ref |
@caniszczyk I will send a formal vote out to the TOB in a few minutes. |
This vote has also definitely passed unanimously with 9/9 approving the new project transfer: Brandon Philips: +1 I'll work with @stevvooe to xfer the repo later this week |
@stevvooe are you around today or tomorrow to do this transfer dance? https://help.github.com/articles/transferring-a-repository-owned-by-your-organization/ "The user transferring a repository must have owner or admin permissions in both organizations to complete a repository transfer." |
The migration has happened: https://github.com/opencontainers/go-digest We still need to do some repo cleanup IMHO, thanks @stevvooe again. FYI @opencontainers/tob |
opencontainers/image-spec#486 introduces a dependency on a stable upstream implementation of https://github.com/docker/go-digest, which was recently broken out of the https://github.com/docker/distribution project.
This package has been instrumental in providing a strong hash-identity implementation in Go and I hope to extend this to OCI.
Let's support this by moving this into a https://github.com/opencontainers/go-digest project specifically oriented towards providing this functionality throughout the container ecosystem. While this package does support opencontainers/image-spec, it is broadly useful in other image formats or outside image formats.
Having a solid, battle-proven, common digest implementation in OCI for use in and outside the image-spec will ensure long lasting security and interoperability throughout the container ecosystem.
Provisions:
@caniszczyk @philips
The text was updated successfully, but these errors were encountered: