Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poststop entry in ocitools-generate(1) says "before the container process is destroyed" #41

Closed
wking opened this issue Apr 28, 2016 · 2 comments

Comments

@wking
Copy link
Contributor

wking commented Apr 28, 2016

See here, with language from #33. The language looks like it's drifting towards the in-flight opencontainers/runtime-spec#395. But however that PR goes down, the container process is gone by the time the post-stop hooks run, because that process existing is the stop event. I'd suggest echoing the spec:

The post-stop hooks are called after the container process is stopped.

although I'd be a bit happier if the spec used “exits” instead of “is stopped” (to avoid confusion with SIGSTOP).

@liangchenye
Copy link
Member

+1, I think we would better synchronize the language used in ocitools with oci spec.

@mrunalp
Copy link
Contributor

mrunalp commented May 18, 2016

Yeah, we can change the man page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants