Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate libcontainer/user, and migrate to github.com/moby/sys/user #4017

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 16, 2023

@thaJeztah
Copy link
Member Author

@opencontainers/runc-maintainers PTAL I didn't tag a version yet, pending if we're all in agreement 😃

(I split this PR into two commits, so that we can potentially cherry-pick the first one into existing release branches).

@thaJeztah
Copy link
Member Author

I guess these are things we could address before tagging a release as well;

Screenshot 2023-09-18 at 22 31 15

go.mod Outdated
@@ -11,6 +11,7 @@ require (
github.com/docker/go-units v0.5.0
github.com/godbus/dbus/v5 v5.1.0
github.com/moby/sys/mountinfo v0.6.2
github.com/moby/sys/user v0.0.0-20230918201840-c0711cde08c8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a tag?

@thaJeztah
Copy link
Member Author

Can we have a tag?

Yes, we can, but I wanted to be sure we were all in agreement (I want this to be a "move" of a package, and not ending up with a (friendly) fork) 😅 #4017 (comment)

I didn't tag a version yet, pending if we're all in agreement

Here's what I'm proposing;

  • Tag v0.1.0 with the module as-is: this tag is a straight move (no changes, other than adding what's required; go.mod etc)
  • Fix things like the camel-casing (LookupUid -> LookupUID etc). Given that we'll be aliasing the functions inside libcontainer/user that change will be transparent to any consumer of libcontainer/user (but consumers should ultimately move)
  • Tag those changes as v0.2.0 ?

Perhaps there's some more cleaning up to do, so I didn't want to move straight on to v1.0.0. SemVer recommendation is to start at v0.1.0 (but of course that's assuming "fresh, new code"; technically a v1.0.0 would be warranted as this code has been used in production already).

@thaJeztah
Copy link
Member Author

I'll have a look at the linting failures (I guess it complains because it's considering it "new code" now)

Also: I'm more than happy to add additional runc maintainers as maintainer on moby/sys, if people want to participate in maintaining that code-base (as it has modules that are common among various projects).

@thaJeztah
Copy link
Member Author

Tagged a v0.1.0

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AkihiroSuda AkihiroSuda merged commit 1d9b158 into opencontainers:main Sep 21, 2023
36 checks passed
@thaJeztah thaJeztah deleted the migrate_libcontainer_user branch September 21, 2023 10:16
@thaJeztah
Copy link
Member Author

Thanks! I'll also have a look at fixing the CameCase nits in moby/sys (for a v0.2.0, or whatever version it will be); for this one I wanted it to be a clean "move"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants