libct/cg: IsCgroup2HybridMode: don't panic #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
added
area/cgroupv1
backport/1.1-todo
|
As a library we should avoid logging but I think this case is probably fine. |
mrunalp
previously approved these changes
Mar 27, 2022
liggitt
reviewed
Mar 27, 2022
In case statfs("/sys/fs/cgroup/unified") fails with any error other
than ENOENT, current code panics. As IsCgroup2HybridMode is called from
libcontainer/cgroups/fs's init function, this means that any user of
libcontainer may panic during initialization, which is ugly.
Avoid panicking; instead, do not enable hybrid hierarchy support and
report the error (under debug level, not to confuse anyone).
Basically, replace the panic with "turn off hybrid mode support"
(which makes total sense since we were unable to statfs its root).
Signed-off-by: Kir Kolyshkin <[email protected]>
Good point! There are a bunch of other places like this in libcontainer unfortunately. Which has to be solved globally (perhaps by having a user-specifiable logger which defaults to "no logging at all". |
mrunalp
approved these changes
Mar 27, 2022
AkihiroSuda
approved these changes
Mar 28, 2022
kolyshkin
added
backport/1.1-done
|
1.1 backport: #3435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
statfs("/sys/fs/cgroup/unified")fails with any error otherthan
ENOENT, current code panics. AsIsCgroup2HybridModeis called fromlibcontainer/cgroups/fs'sinitfunction, this means that any user oflibcontainer may panic during initialization, which is ugly.
Avoid panicking; instead, do not enable hybrid hierarchy support and
report the error (under debug level, not to confuse anyone).
Basically, replace the panic with "turn off hybrid mode support"
(which makes total sense since we were unable to statfs its root).
This is an alternative to #3432. The bug is originally reported by @liggitt
in kubernetes/kubernetes#109029 (review)