Drop Go 1.15 support #3245
Drop Go 1.15 support #3245
Conversation
|
The commit message "Require Go <= 1.16" looks like it's the wrong way around. |
|
kolyshkin
force-pushed
the
go116
branch
2 times, most recently
from
109b436
to
2cc4061
Compare
|
YUP 😔 moby/moby#42935 |
Jobs verify/compile-buildtags and verify/deps relied on whatever Go version is available from the Ubuntu-20.04 image, which seems to be 1.15.x). Job test/cross-i386 was installing whatever Go version is considered to be the default one by actions/setup-go@v2, which seems to be go 1.15.15 at the moment. Fix all three jobs to install Go 1.x (which should translate to latest stable Go version, i.e. 1.17.2 as of now). Signed-off-by: Kir Kolyshkin <[email protected]>
Go 1.15 is not supported since Go 1.17 release (16 Aug 2021), and some packages that we use already require Go 1.16+ (notably, github.com/cilium/ebpf v0.7.0). Let's require Go 1.16+. Remove Go version requirement from README when describing dependencies, since it is no longer needed: $ GO=go1.15.15 make vendor go1.15.15 mod tidy go mod tidy: go.mod file indicates go 1.16, but maximum supported version is 1.15 make: *** [Makefile:141: vendor] Error 1 Signed-off-by: Kir Kolyshkin <[email protected]>
One less TODO in the code, yay! Signed-off-by: Kir Kolyshkin <[email protected]>
See https://golang.org/doc/go1.16#ioutil Signed-off-by: Kir Kolyshkin <[email protected]>
|
Rebased on top of just merged #3246; should fix CI |
|
This one is ready to go, @AkihiroSuda @thaJeztah PTAL I have removed go 1.15 checks from the list of required ones. Close/reopen to kick CI. |
|
@thaJeztah @cyphar PTAL |
Drop Go 1.15 support, requiring Go >= 1.16. Motivated by #3242 (comment), should unblock that PR.
The last commit drops use of
io/ioutil, which is not really required and can be postponed for later time (say after Go 1.18 release, which will probably mark ioutil package as deprecated).