fs2: fallback to setting io.weight if io.bfq.weight #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
reviewed
Feb 24, 2021
libcontainer/cgroups/fs2/io.go
Outdated
| return err | ||
| // if io.bfq.weight does not exist, then bfq module is not loaded. | ||
| // Fallback to use io.weight with a conversion scheme | ||
| if os.IsNotExist(err) { |
There was a problem hiding this comment.
I'd rather do
if !os.IsNotExist(err) {
return err
}
// Fallback to use io.weight.
...just for readability
if bfq is not loaded, then io.bfq.weight is not available. io.weight should always be available and is the next best equivalent thing. Signed-off-by: Daniel Dao <[email protected]>
dqminh
force-pushed
the
io-cgroup2-fallback
branch
from
669f92b
to
8c7ece1
Compare
AkihiroSuda
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if bfq is not loaded, then io.bfq.weight is not available. io.weight
should always be available and is the next best equivalent thing.
Signed-off-by: Daniel Dao [email protected]