Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: add --no-delete to runc run #2817

Closed
tonistiigi opened this issue Feb 22, 2021 · 5 comments · Fixed by #2825
Closed

proposal: add --no-delete to runc run #2817

tonistiigi opened this issue Feb 22, 2021 · 5 comments · Fixed by #2825
Milestone

Comments

@tonistiigi
Copy link
Contributor

runc run is much more simple to use than create/start async commands that are almost impossible to use safely without introducing a special shim-like binary to deal with SIGCHLD reaper issues.

One of the problems though is that when using run calling process can't get the full stats of the process because cgroups are already deleted when it returns. Could we consider adding --no-delete option that leaves cgroups and other resources in place so the caller can analyze them and then call runc delete to do the manual cleanup.

@lifubang
Copy link
Member

+1

@AkihiroSuda AkihiroSuda added this to the post-1.0 milestone Feb 23, 2021
@kolyshkin
Copy link
Contributor

Maybe --keep-cgroups? I'm not sure what are the other resources (except maybe intel RDT).

@lifubang
Copy link
Member

Maybe --keep-cgroups? I'm not sure what are the other resources (except maybe intel RDT).

Besides cgroup paths, we should keep runc state dir to allow us use runc delete to delete the cgroup paths, so I'd prefer to use --no-delete.

@lifubang
Copy link
Member

It's very easy to implement. Please see #2825 .

@lifubang
Copy link
Member

As described in #2825 (comment)
We suggest change --no-delete to --keep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants