Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsexec logging is racy (aka "debug.bats is flaky") #2756

Closed
kolyshkin opened this issue Jan 20, 2021 · 0 comments · Fixed by #2835
Closed

nsexec logging is racy (aka "debug.bats is flaky") #2756

kolyshkin opened this issue Jan 20, 2021 · 0 comments · Fixed by #2835

Comments

@kolyshkin
Copy link
Contributor

kolyshkin commented Jan 20, 2021

Sometimes debug.bats test cases are failing like this:

not ok 27 global --debug to --log --log-format 'json'
# (in test file tests/integration/debug.bats, line 77)
#   `[[ "${output}" == *"child process in init()"* ]]' failed

This is caused by the fact that log forwarding from nsexec is not waiting for all logs to be written to disk ( before runc process ends, and in case of short-lived processes this result in missing debug from nsexec.

This happens when writing to disk, and may probably be made 100% reproducible by slowing down disk I/O.

This is probably not an issue for any real customers (no one except developers is interested in nsexec debug log), but it's at least an issue with the test (thus the subject).

I tried to fix it in #2487 (last commit) but it needs more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant