Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language on client side referrer list generation to mention replace #514

Open
dmcgowan opened this issue Feb 15, 2024 · 2 comments
Open
Milestone

Comments

@dmcgowan
Copy link
Member

When a client pulls down a referrer list to add a new referrer, the current language instructs the client to "append" to the list, however the client should also have the option to "replace" referrers in the list.

@dmcgowan dmcgowan added this to the v1.1.1 milestone Feb 15, 2024
@sudo-bmitch
Copy link
Contributor

Currently the manifest delete workflow describes the process to delete an entry from the referrers response when deleting a manifest that has a subject. If we add a replace workflow, would there be a similar process to automatically delete manifests on the push of a new manifest for registries that implement the referrers response? And if so, how should registries that do not support the delete APIs respond to those requests?

@dmcgowan
Copy link
Member Author

The manifest delete workflow would not work with the fallback in any case. It would be reasonable for a registry to reject the delete of a manifest that is currently being referred to via another manifest, such as a referrers index.

I think we should likely add more language about the management and subject manifest, including how a "replace" may work in both the fallback and non-fallback case. There is certainly a hole there where a registry could support the referrers endpoint without supporting manifest delete API. I was thinking of opening a separate issue to discuss how we should update the dynamic content generation language to provide clearer guidance on management of subject manifest (removing, auto-pruning, ordering). The fallback case is more straightforward though since a client can simply replace or remove stale descriptors without worrying about manifest delete. We could add should language about only replacing or removing descriptors of the same or known artifact type though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants