Enhancements for MPLS support #1181
Conversation
Signed-off-by: Ann Pokora <[email protected]>
inc/saiswitch.h
Outdated
| * @flags READ_ONLY | ||
| */ | ||
| SAI_SWITCH_ATTR_AVAILABLE_MPLS_INSEG_ENTRY, | ||
|
|
There was a problem hiding this comment.
Please consider using sai_object_type_get_availability()
This is generic object CRM API, replacing the old approach of specific attribute per object
There was a problem hiding this comment.
Is there an example of this that I can see? I don't see any usage of sai_object_type_get_availability() in latest CrmOrch.cpp.
There was a problem hiding this comment.
The PR has examples
ef89cb2#diff-1f169362ad7823ade5ade3918ba6a35fe17189e13d7f05a8b9edf2f6aeccc5f8
There was a problem hiding this comment.
AFAIK, Sonic hasn't yet ported existing CRM code to the new API, but is using the new API for new objects, such as debug counters
There was a problem hiding this comment.
ef89cb2#diff-1f169362ad7823ade5ade3918ba6a35fe17189e13d7f05a8b9edf2f6aeccc5f8
Shows usage examples
Signed-off-by: Ann Pokora <[email protected]>
| * | ||
| * @type bool | ||
| * @flags CREATE_AND_SET | ||
| * @default false |
There was a problem hiding this comment.
default it to true? just like IPv4 and IPv6?
This PR defines missing support for MPLS as compared to equivalent IPv4/IPv6 support: