Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken expense category links #400

Closed
znarf opened this issue May 15, 2018 · 1 comment
Closed

Broken expense category links #400

znarf opened this issue May 15, 2018 · 1 comment

Comments

@znarf
Copy link
Member

znarf commented May 15, 2018

On a collective page like https://opencollective.com/yeoman, expense categories links are invalid.

screen shot 2018-05-15 at 11 05 37

It should be /yeoman/expenses/categories/Web%20services not /yeoman/expenses/Web%20services.

Also, the slug should be properly encoded: Web%20services not Web services
@znarf znarf added the bug label May 15, 2018
znarf added a commit that referenced this issue May 17, 2018
@znarf
fix(expenses): fix navigation between categories
7b9e2bf 
also stop scrolling to top when navigating

Closes #400
znarf added a commit that referenced this issue May 17, 2018
@znarf
fix(expenses): fix navigation between categories
886eaaa 
also stop scrolling to top when navigating

Closes #400
@znarf znarf mentioned this issue May 17, 2018
Merged
@znarf
Copy link
Member Author

znarf commented May 17, 2018

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@znarf