-
-
Notifications
You must be signed in to change notification settings - Fork 11
Format docstrings so they pass pydocstyle
's criteria
#81
Comments
Hi! I'm a data scientist living in Seattle, USA. I am looking to get more involved in open source projects tackling the climate crisis. I think that your project is really interesting, and I'd love to help you by working on this issue (and perhaps the similar issues in other repos). Would you be open to this contribution from me? |
Hey! Thanks so much for getting in touch! We'd definitely welcome your contributions! On this specific issue, I should check something: @jacobbieker & @peterdudfield are we still planning to use pydocstyle; and do |
Hi @mfrasco, thanks for getting involved. @JackKelly yes we are still planning to use pydocstyle. This has been implemented for Nowcasting_dataset and Nowcasting_utils. And yes 'predict_pv_yield' does need updating It looks like work on a big 'joint' model (openclimatefix/satflow#101) has started in Satflow. Perhaps it would be good to add 'pydocstyle' to this repo first. I mention this so that the work for this issue is most useful. Thoughts? |
Sure, sounds good! @mfrasco would you be happy to work on openclimatefix/satflow#97? (Which is still formatting docstrings; but in the SatFlow repo!) |
Definitely! I can do that. |
Fantastic, thank you! |
Thanks very much @mfrasco |
Thanks @mfrasco! I can also help with a lot of the SatFlow stuff, if any of it is confusing! |
Detailed Description
We plan to use
pydocstyle
to automatically check that our docstrings conform to a standard format. It would be amazing to have help tweaking our existing docstrings to conform!pydocstyle
's list of criteria is here: http://www.pydocstyle.org/en/stable/error_codes.htmlHere's the Pull Request (and discussion) about enabling
pydocstyle
fornowcasting_utils
: openclimatefix/nowcasting_utils#23The text was updated successfully, but these errors were encountered: