Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCart Installation - extra forward-slash in directory listing #3614

Closed
jremes-foss opened this issue Nov 9, 2015 · 5 comments
Closed

Comments

@jremes-foss
Copy link
Contributor

Hi.

After updating OpenCart repository locally (fresh working copy, no changes made), I noticed this on the installation screen, in permissions section:

/var/www/html/opencart/upload/system//storage/cache/.

I do suspect that there's an extra forward-slash somewhere in installation/setup file.

No further changes made, so I do suspect this is in default settings somewhere.

Screenshot attached.
opencart_installation

@danielkerr
Copy link
Member

wasting my time!

server software being used?
permissions on the directories!

can the web user even read the folder!

i should guess everything!

@gilsamuelaraujo
Copy link
Contributor

I think daniel
https://github.com/opencart/opencart/blob/master/upload/install/controller/step_2.php#L90
has an extra / @Newman101 is refereing to. as a quick browse.

    $data['image_catalog'] = DIR_OPENCART . 'image/catalog';
    $data['cache'] = DIR_SYSTEM . '/storage/cache';
    $data['logs'] = DIR_SYSTEM . 'storage/logs';
    $data['download'] = DIR_SYSTEM . 'storage/download';
    $data['upload'] = DIR_SYSTEM . 'storage/upload';

#3615 proposal if you agree Daniel

@gilsamuelaraujo
Copy link
Contributor

@Newman101 Daniel merged the fix. Thank you
meanwhile in your installation you might be able to fix it by browsing to your config.php files on both root and /admin folders and correct the path in there. to prevent a new install.

Regards

@jremes-foss
Copy link
Contributor Author

You're welcome. My installation works fine, it was just the extra forward slash which actually had my attention. I reported it because I thought it might cause adverse effects in the future.

@gilsamuelaraujo
Copy link
Contributor

@Newman101 no clue the implications of that extra slash in the long term, but its fixed now
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants