Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin mobile content outside of viewport when navigation menu is open #1791

Closed
bull5-i opened this issue Aug 31, 2014 · 5 comments
Closed

Admin mobile content outside of viewport when navigation menu is open #1791

bull5-i opened this issue Aug 31, 2014 · 5 comments

Comments

@bull5-i
Copy link

bull5-i commented Aug 31, 2014

Currently when viewing the admin pages in a mobile device with screen width less than 768px with the navigation menu is opened, the page content is pushed off the screen due to following stylesheet rule in
/upload/admin/view/stylesheet/stylesheet.css:

@media (max-width: 767px) {
#column-left.active + #content {
    position: relative;
    left: 235px;
}
}

Pushing content off the screen so it is not accessible is definitely not the right thing to do. Instead I would use margin-left: 235px; (this way the #content div width will be reduced to what is left of the 235px margin) or _even better_ left: 0; so the navigation menu will overlay the #content div which will keep the full page width. With such small screen sizes keeping the navigation menu opened while viewing or modifying content is not practical anyway, so overlaying the menu seems to be more appropriate solution.

@mhcwebdesign
Copy link
Collaborator

Using a responsive theme for the admin side of OpenCart is IMHO a questionable choice. There are lot of admin pages where the main contents simply won't fit the display of smaller mobile devices.

@bull5-i
Copy link
Author

bull5-i commented Sep 1, 2014

Fortunately Bootstrap framework enables mobile first approach and I think mobile is the way to go.

@bull5-i
Copy link
Author

bull5-i commented Sep 2, 2014

Why has the issue been closed without a fix?

@danielkerr
Copy link
Member

it was deigned this way. the whole window moves without squashing the content when in mobile view.

@bull5-i
Copy link
Author

bull5-i commented Sep 3, 2014

You could get the same result (not squashing the content) by overlaying the menu (using the left:0 proposed fix). Overlaying navigation menus on mobile views is widely used solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants