Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong utf8_substr default param usage in filemanager.php #1322

Closed
anilex opened this issue Apr 9, 2014 · 1 comment
Closed

Wrong utf8_substr default param usage in filemanager.php #1322

anilex opened this issue Apr 9, 2014 · 1 comment

Comments

@anilex
Copy link

anilex commented Apr 9, 2014

When having $length = 0 in

function utf8_substr($string, $offset, $length = 0) {
    return mb_substr($string, $offset, $length);
}

the utf8_substr($directory, strlen(DIR_IMAGE . 'data/')); used in filemanager controller return string with zero length.

So.. we should overwrite the default length value with null ie. utf8_substr($directory, strlen(DIR_IMAGE . 'data/'), null); or we should remove default value for $length

@danielkerr
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants