-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Error reading from tty device" message on startup. #6
Comments
Committed a fix at: https://gerrit.openbmc-project.xyz/#/c/848/
@williamspatrick , @jk-ozlabs . Please review. |
Updated the patch - when there is revent besides POLLIN, we cannot do continue, otherwise we cannot poll clients (call_pollers(console)) - clients may hang there. Is it OK just read from tty when revent==POLLIN? I tested on Palmetto, and I cannot reproduce the issue any more, and obmc-console-client works well. |
Needs 1 more +1 and then merge. Please follow up with reviewers. |
Hi @shenki , will you have a look and +1 :) |
@jk-ozlabs commented in: https://gerrit.openbmc-project.xyz/#/c/848/, that "Why are you ignoring POLLERR & POLLHUP? This seems dangerous." |
Seem pretty open now, and priority isn't clear so just putting in actual for current sprint (not committed). |
@adamliyi - Patrick would like to see this one get resolved, please follow up with Joel on a correct solution this next sprint. Thanks! |
From @jk-ozlabs, we have several commits under review: the patch series of https://gerrit.openbmc-project.xyz/#/c/2316 |
I sometimes observe the following on startup. Due to the restart policy, we get the service immediately restarted and it works fine after that.
The text was updated successfully, but these errors were encountered: