Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broader usage of Paginated Lists #271

Closed
1 of 7 tasks
cipherboy opened this issue Apr 6, 2024 · 4 comments · Fixed by #678
Closed
1 of 7 tasks

Broader usage of Paginated Lists #271

cipherboy opened this issue Apr 6, 2024 · 4 comments · Fixed by #678
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cipherboy
Copy link
Member

cipherboy commented Apr 6, 2024

Is your feature request related to a problem? Please describe.

In #140 and #170, initial support of paginated lists were added, which included some API endpoints. However, some more endpoints could be updated to use these new APIs.

Describe the solution you'd like

  • PKI Tidy operation should use paginated lists everywhere. in Add pagination to tidy  #678 thanks to @fatima2003!
  • Audit other tidy operations for usage of paginated lists
  • Lease expiry should use paginated lists
  • Token expiry should use paginated lists
  • Secrets and auth engine listing should probably support pagination as well. This does not use a storage.List call but could still be made transactional. Transactional added in Split mount tables with transactions #622, but should still manually support pagination even though it won't be any more efficient.
  • Policy listing should also use this, even though it uses a recursive storage view.
  • Additional calls to storage.List should probably be audited as well.

Describe alternatives you've considered

Some places will continue to rely on storage.List as they have a low volume of responses, e.g., issuer counts should be in the 10s at most.

Explain any additional use-cases

Some additional use cases are available at the HashiCorp Vault issue: hashicorp/vault#10887

Additional context

This will help with memory utilization in more high-volume areas of the code. Would be a good GA milestone candidate.

@cipherboy cipherboy added the feature New feature or request label Apr 6, 2024
@naphelps naphelps added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 8, 2024
@lplazas
Copy link

lplazas commented Apr 30, 2024

I'd be happy to get this assigned to me.

@cipherboy
Copy link
Member Author

@lplazas I think a great place to start would be the PKI engine. While large, I think the changeset should mostly be limited to https://github.com/openbao/openbao/blob/main/builtin/logical/pki/path_tidy.go :-)

@cipherboy
Copy link
Member Author

cipherboy commented Jun 16, 2024

\o hey @lplazas! As a FYI, I'm tackling the ones in the PKI engine ahead of GA, but let me know if you're not interested in this any more and I can tackle the rest :-) Or if you have any questions, feel free to tag me or contact me!

@fatima2003
Copy link
Contributor

Hi @cipherboy, I will be working on using pagination in PKI tidy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants