Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trends command #17

Open
majesticio opened this issue Aug 31, 2023 · 3 comments
Open

add trends command #17

majesticio opened this issue Aug 31, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@majesticio
Copy link
Contributor

majesticio commented Aug 31, 2023

openaq trends would require measurands_id and and locations_id so I am not sure what is the best way to implement it. Could be
openaq trends location 2178 measurand 2. Likely would only be for power users so they may be willing to put in the effort. Would also need to include optional flags for --period (month, day, year) --from and --to

@majesticio majesticio added the enhancement New feature or request label Aug 31, 2023
@majesticio
Copy link
Contributor Author

perhaps would be better as an optional flag for locations?
openaq locations get 2178 --trends 2 <-- 2 is the measurand ID. This seems a bit clunky

@russbiggs
Copy link
Member

This is a tough one. I htink the most semantic way to do it would be:

openaq trends list 2178 2

i.e. require two positional args: [locationsID] then [parametersID]. The positional args can feel a little arbitrary but woudl be the most standard way of doing it.

@majesticio
Copy link
Contributor Author

majesticio commented Sep 8, 2023

needed flags:

  • --page
  • --limit
  • --from
  • --to
  • --period

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants