Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False Not Enacted in Nightscout with Dev 0.6.0-dev #637

Closed
ELUTE opened this issue Sep 4, 2017 · 19 comments
Closed

False Not Enacted in Nightscout with Dev 0.6.0-dev #637

ELUTE opened this issue Sep 4, 2017 · 19 comments

Comments

@ELUTE
Copy link

ELUTE commented Sep 4, 2017

Nightscout reporting not enacted but rig is working. Only started when updated to 0.6.0-dev
screen shot 2017-09-04 at 4 23 33 pm

@scottleibrand
Copy link
Contributor

What does the pump-loop.log run look like?

@ELUTE
Copy link
Author

ELUTE commented Sep 4, 2017

screen shot 2017-09-04 at 4 43 49 pm

@philipgo
Copy link
Contributor

philipgo commented Sep 4, 2017

We experience the same error on the 0.6.0-dev and cob-aware-autosens branches. Nightscout works fine with all other branches. Boluses and basal rates are uploaded without any issues.

pump-loop.log.txt

@philipgo
Copy link
Contributor

philipgo commented Sep 4, 2017

I think I may have found a possible cause. In the mlab devicestatus entries the word "received" is spelt differently in the enacted-section.
0.5.3: "recieved": true,
0.6.0: "received": true,

@scottleibrand
Copy link
Contributor

There is a dependency on a new version of openaps that fixes the spelling. Did you reinstall and re-run oref0-setup? I believe it will upgrade openaps for you.

@philipgo
Copy link
Contributor

philipgo commented Sep 4, 2017

I reflashed the rig to jubilinux 0.2.0, installed the current master, switched to 0.6.0-dev and did npm run global-install and then re-ran oref0-setup. 0.5.3-entries containing the wrong spelling "recieved" work fine. Could the correct spelling "received" be the problem because Nightscout does not parse it?

@PieterGit
Copy link
Contributor

PieterGit commented Sep 4, 2017

Can also confirm this bug, on a fresly installed jubilinux 0.1.1 with 0.6.0-dev rig (installed with oref0-setup and npm run global-install).

# openaps --version
openaps 0.2.1-dev

@philipgo
Copy link
Contributor

philipgo commented Sep 4, 2017

Changing the spelling back to "recieved" in enacted.json leads to a correct "Enacted" display on Nightscout.

@PieterGit
Copy link
Contributor

PieterGit commented Sep 4, 2017

Found the problem in Nightscout:
https://github.com/nightscout/cgm-remote-monitor/blob/d407bab2096d739708f365eae3c78847291bc997/lib/plugins/openaps.js#L111-L112

I can make a PR to Nightscout later this week or this weekend (including adding a test to tests/openaps.test.js), but I don't mind if somebody beats me to it.
So oref0 0.6.0 (or openaps 0.2.1-dev) will require the next Nightscout release. Technically we should up the major version of openaps to 1.0.0 according to semver.org rules.

@philipgo
Copy link
Contributor

The fix has now been merged into the Nightscout dev branch. I think this issue can be closed.

@ELUTE
Copy link
Author

ELUTE commented Sep 18, 2017

It is not fixed in Dev for me. The issue is still there.

@philipgo
Copy link
Contributor

You are running OpenAPS 0.6.0-dev and updated your Nightscout to the latest dev version less than 7 days ago and still get the "Not enacted" message in the OpenAPS pill in Nightscout although the rig is looping without any problems?

@ELUTE
Copy link
Author

ELUTE commented Sep 18, 2017

Correct
screen shot 2017-09-18 at 5 16 47 pm

@philipgo
Copy link
Contributor

Could you post an mLab devicestatus entry that should display as enacted but does not?

@ELUTE
Copy link
Author

ELUTE commented Sep 18, 2017

screen shot 2017-09-18 at 5 26 23 pm

@PieterGit
Copy link
Contributor

@ELUTE It's fixed in Nightscout, not in oref0. Did you upgrade your Nightscout to the dev branch?

@philipgo
Copy link
Contributor

If you could copy and paste the text I could paste it into my database and see what happens.

@ELUTE
Copy link
Author

ELUTE commented Sep 18, 2017

@PieterGit I have always used Dev. I am running the latest commit

@ELUTE
Copy link
Author

ELUTE commented Sep 19, 2017

Apologies. My computer was caching. I will close now as it is resolved.

@ELUTE ELUTE closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants