simplify package installation by removing ffmpeg cli install #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit: you no longer have to accept this PR, just created a new package including this feature: https://github.com/fcakyon/pywhisper
This PR reaplaces
ffmpeg cli tool
+ffmpeg-python package
withmoviepy package
without any difference in audio waveform values.This PR removes the external cli tool dependency and simplifies installation since pip install would be enough.
I have tested with
tests/jfk.flac
file andload_audio()
output is exactly same as before:Also tested with a 1h43min video, works without any issues.
moviepy: https://github.com/Zulko/moviepy