From 51e7ebb1a662aedc613cf26eca415d43fedba846 Mon Sep 17 00:00:00 2001
From: "stainless-app[bot]"
 <142633134+stainless-app[bot]@users.noreply.github.com>
Date: Mon, 7 Oct 2024 13:52:45 +0000
Subject: [PATCH] fix(client): avoid OverflowError with very large retry counts
 (#1779)

---
 src/openai/_base_client.py | 3 ++-
 tests/test_client.py       | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/openai/_base_client.py b/src/openai/_base_client.py
index c4c9803e74..931cbd8534 100644
--- a/src/openai/_base_client.py
+++ b/src/openai/_base_client.py
@@ -690,7 +690,8 @@ def _calculate_retry_timeout(
         if retry_after is not None and 0 < retry_after <= 60:
             return retry_after
 
-        nb_retries = max_retries - remaining_retries
+        # Also cap retry count to 1000 to avoid any potential overflows with `pow`
+        nb_retries = min(max_retries - remaining_retries, 1000)
 
         # Apply exponential backoff, but not more than the max.
         sleep_seconds = min(INITIAL_RETRY_DELAY * pow(2.0, nb_retries), MAX_RETRY_DELAY)
diff --git a/tests/test_client.py b/tests/test_client.py
index 463174465c..1da35ddd22 100644
--- a/tests/test_client.py
+++ b/tests/test_client.py
@@ -697,6 +697,7 @@ class Model(BaseModel):
             [3, "", 0.5],
             [2, "", 0.5 * 2.0],
             [1, "", 0.5 * 4.0],
+            [-1100, "", 7.8],  # test large number potentially overflowing
         ],
     )
     @mock.patch("time.time", mock.MagicMock(return_value=1696004797))
@@ -1553,6 +1554,7 @@ class Model(BaseModel):
             [3, "", 0.5],
             [2, "", 0.5 * 2.0],
             [1, "", 0.5 * 4.0],
+            [-1100, "", 7.8],  # test large number potentially overflowing
         ],
     )
     @mock.patch("time.time", mock.MagicMock(return_value=1696004797))