Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(azure/tts): avoid stripping model param #999

Merged
merged 3 commits into from
Aug 16, 2024
Merged

fix(azure/tts): avoid stripping model param #999

merged 3 commits into from
Aug 16, 2024

Conversation

deyaaeldeen
Copy link
Contributor

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

No longer deleting the model property in Azure requests because tts deployments require it.

Additional context & links

@deyaaeldeen deyaaeldeen requested a review from a team as a code owner August 16, 2024 00:48
@deyaaeldeen deyaaeldeen changed the title Azure/fix tts [Azure] Fix tts required model issue Aug 16, 2024
@stainless-app stainless-app bot changed the title [Azure] Fix tts required model issue fix(azure/tts): dont strip model param Aug 16, 2024
@stainless-app stainless-app bot changed the base branch from master to next August 16, 2024 01:00
@stainless-app stainless-app bot changed the title fix(azure/tts): dont strip model param fix(azure/tts): avoid stripping model param Aug 16, 2024
@stainless-app stainless-app bot merged commit c3a7ccd into openai:next Aug 16, 2024
2 checks passed
@stainless-app stainless-app bot mentioned this pull request Aug 16, 2024
Merged
stainless-app bot pushed a commit that referenced this pull request Aug 16, 2024
@deyaaeldeen @stainless-app
fix(azure/tts): avoid stripping model param (#999)
0121251 
* [Azure] Fix tts required model issue

* add tests

* remove console.log call
@hiterharris hiterharris mentioned this pull request Sep 6, 2024
Closed
@diaz-rigo diaz-rigo mentioned this pull request Sep 6, 2024
Open
@hiterharris hiterharris mentioned this pull request Sep 7, 2024
Closed
@diaz-rigo diaz-rigo mentioned this pull request Sep 7, 2024
Open
@nickyfr33ze nickyfr33ze mentioned this pull request Sep 7, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 9, 2024
Open
@atulgoel126 atulgoel126 mentioned this pull request Sep 11, 2024
Open
@maleeshaaa maleeshaaa mentioned this pull request Sep 15, 2024
Open
@Sandaru-IT21001352 Sandaru-IT21001352 mentioned this pull request Sep 15, 2024
Open
@hiterharris hiterharris mentioned this pull request Sep 18, 2024
Closed
@maleeshaaa maleeshaaa mentioned this pull request Sep 18, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 18, 2024
Open
@maleeshaaa maleeshaaa mentioned this pull request Sep 19, 2024
Open
@roebi roebi mentioned this pull request Sep 19, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
@hiterharris hiterharris mentioned this pull request Sep 20, 2024
Closed
@diaz-rigo diaz-rigo mentioned this pull request Sep 24, 2024
Open
@hiterharris hiterharris mentioned this pull request Sep 25, 2024
Closed
@diaz-rigo diaz-rigo mentioned this pull request Sep 25, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 25, 2024
Open
@diaz-rigo diaz-rigo mentioned this pull request Sep 26, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 26, 2024
Open
@diaz-rigo diaz-rigo mentioned this pull request Sep 27, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 27, 2024
Open
@diaz-rigo diaz-rigo mentioned this pull request Sep 28, 2024
Open
This was referenced Sep 28, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertCraigie RobertCraigie RobertCraigie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deyaaeldeen @RobertCraigie