access model data by name #389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszlitwin
force-pushed
the
mlitwin-getters-by-name
branch
4 times, most recently
from
99ba217
to
db7a9a9
Compare
mateuszlitwin
force-pushed
the
mlitwin-getters-by-name
branch
from
db7a9a9
to
3208217
Compare
mateuszlitwin
changed the title
mateuszlitwin
changed the title
|
What's the status of this PR? |
|
Waiting for feedback if this make sense. |
|
I think it may be useful in some cases. Could use as well some tests/examples. In general my take though is to expose less in MjSim and more task-relevant functionality in a layer on top. What do you think about detecting argument type (string, list[string], int, array[int], etc.) and returning suitable result depending on that? |
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ###### const from defines ###### | |||
| MINVAL = 1e-15 # minimum value in any denominator | |||
| PI = 3.141592653589793 # | |||
| PI = 3.141592653589793 # | |||
There was a problem hiding this comment.
This is accidental I guess?
|
I'm doing a review of open mujoco-py PRs. Do you still want to work on this one @mateuszlitwin ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.