Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A issue about the saving the model in train.py #69

Open
chengdusunny opened this issue Mar 2, 2022 · 0 comments
Open

A issue about the saving the model in train.py #69

chengdusunny opened this issue Mar 2, 2022 · 0 comments

Comments

@chengdusunny
Copy link

Hello, I am very interested in this project. However, although the work is almost perfect, I think there still be some amendment to this.
Please refer to the line in train.py:
if terminal and (len(episode_rewards) % arglist.save_rate == 0):
I think your intention is that if the current episode has ended and the number of episodes is divisible by arglist.save_rate, then save the tained model and display the information.
However, terminal should be replaced by (terminal or done), since the episode can also be ended if the agents are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant