-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add rabbitmq msg for announcer #1845
Conversation
Pull Request Test Coverage Report for Build 4553
💛 - Coveralls |
abbcf48
to
c71c685
Compare
c71c685
to
085dc22
Compare
This would seem to be backwards. OBS should be emitting an event that the announcer listens for to send out an e-mail. |
In this case OBS is not sufficient, the factory-package-news script is invoked by openQA after a new changelog is created (I think). But I tend to agree with you, this process seems the wrong way around. @DimStar77 you probably know more about this and what the right procedure is. |
OBS sends out an event if openSUSE:Factory:ToTest/images is published - containing this ISO. I wonder what's your use case. |
I would like to run a build using the fresh Tumbleweed image, once it got released. Originally I wanted to listen for the rabbitmq event that ttm sends around, but Dominique told me that they are probably firing too soon and that OBS still has to do the release afterwards. |
the problem at this time is that download.o.o will only be updated in like 2 - 3 hours, as we hold off the switch for mirrors to catch up. Hence the idea of the announcer also creating an event - as it actually monitors when the publishing is actually really done and ready for users to consuime download.o.o again Preferably this event would come from another place, like the "publisher holding off"-script for example, at the time when it does the switch - but anybody daring to touch that code will curse for the rest of his life IFF we would add rabitmq to the publisher scripts, then of course the announcer would/could/should listen as well |
/me remembers a proposal on this topic. oh well. |
now that explains @lnussel's behavior! :) |
Since I am quite inexperienced with the openSUSE infrastructure, what do you all think that should be done about this? If this is not the way forward, I'd rather close this and discuss a better solution in #1834. |
This fixes #1834.
The whole code is untested, since I wasn't able to find any test code for
announcer.py
. I would be more than happy to add some tests to this, as I have absolutely no idea whether this works.