Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for units #209

Open
RemiLehe opened this issue May 24, 2018 · 2 comments
Open

Add support for units #209

RemiLehe opened this issue May 24, 2018 · 2 comments
Assignees

Comments

@RemiLehe
Copy link
Member

Right now, openPMD-viewer converts all units to SI, but then it does not show the unit name on the axes.

In order to fix this, one would need to:

  • Write a function that queries the dimension of each retrieved quantity, and finds the matching SI unit.
  • Add this to the labels.

For fields, the units could also be stored in the FieldMetaInformation object.

@RemiLehe RemiLehe self-assigned this May 24, 2018
@ax3l
Copy link
Member

ax3l commented May 24, 2018

True, do you mean colorbar axes?

Slightly related to #64

@RemiLehe
Copy link
Member Author

Yes, colorbar axes, as well as vertical/horizontal axes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants