Fix groupIds of TermCodes #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For TermCodes belonging to multiple groups, the groupIds attribute contained a mixture of group ids and group names. This changes it to the actual group ids.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
=========================================
Coverage 71.88% 71.88%
Complexity 7043 7043
=========================================
Files 670 670
Lines 22989 22989
Branches 3729 3729
=========================================
Hits 16526 16526
Misses 4717 4717
Partials 1746 1746 ☔ View full report in Codecov by Sentry. |
MattijsK
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For TermCodes belonging to multiple groups, the groupIds attribute contained a mixture of group ids and group names. This changes it to the actual group ids.
Regenerated fullTermFile.json according to the README