Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Argmax deprecated #99

Closed
aakashsur opened this issue Dec 20, 2017 · 2 comments
Closed

Warning: Argmax deprecated #99

aakashsur opened this issue Dec 20, 2017 · 2 comments

Comments

@aakashsur
Copy link

Hi, I got a warning:

/usr/local/lib/python2.7/dist-packages/cooler/_binning.py:81: FutureWarning: 'argmax' is deprecated. Use 'idxmax' instead. The behavior of 'argmax' will be corrected to return the posi
tional maximum in the future. Use 'series.values.argmax' to get the position of the maximum now.
  chrmax = loadings.argmax()

I assume this is related to numpy/pandas, but I couldn't tell, not sure if it will make any impact, but I thought I would mention it.

@nvictus
Copy link
Member

nvictus commented Dec 20, 2017

Thanks! I've noticed it recently too. It's a warning for future pandas behavior, so we'll make sure to fix it in the next release.

@nvictus
Copy link
Member

nvictus commented Mar 16, 2018

Done!

@nvictus nvictus closed this as completed Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants