Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: manifest v1 and lit 2 #63

Closed
wants to merge 1 commit into from

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Oct 18, 2021

Fixes #61

What I Did

  1. update most dependencies
  2. use the types from the v1 custom-elements manifest
    • still some clean up work to do matching class fields to attributes
  3. wip migration to lit 2
    • the directives need some attention here, I could use a hand
  4. wip es-dev-server -> wds

If the general direction seems agreeable, let's continue

Most of the mechanical migration is done. It seems to me the last things needed are:

  • port the custom directive to lit 2
  • rework the concept of knobs to accept manifest v1

For knobs, I think probably the way to go here is to either
1. create our own modified manifest data structure when the manifest is loaded
2. separate the knobs data structure entirely from the manifest structure

@web-padawan
Copy link
Collaborator

Thanks for the PR. I will start from version bumps and port some of them to master so you can rebase.

@bennypowers
Copy link
Member Author

closing in favour of #84

@bennypowers bennypowers closed this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Custom Elements Manifest 1.0.0?
2 participants